catch errors in multiple places that might be destroying the async flow and causing lnbits to die silently.

lnbits/extensions/amilk/views_api.py

@@ -37,12 +37,15 @@ async def api_amilkit(amilk_id):
     except LnurlException:
         abort(HTTPStatus.INTERNAL_SERVER_ERROR, "Could not process withdraw LNURL.")
 
-    payment_hash, payment_request = await create_invoice(
-        wallet_id=milk.wallet,
-        amount=withdraw_res.max_sats,
-        memo=memo,
-        extra={"tag": "amilk"},
-    )
+    try:
+        payment_hash, payment_request = await create_invoice(
+            wallet_id=milk.wallet,
+            amount=withdraw_res.max_sats,
+            memo=memo,
+            extra={"tag": "amilk"},
+        )
+    except Exception as e:
+        return jsonify({"message": str(e)}), HTTPStatus.INTERNAL_SERVER_ERROR
 
     r = httpx.get(
         withdraw_res.callback.base,

lnbits/extensions/bleskomat/models.py

@@ -86,10 +86,13 @@ class BleskomatLnurl(NamedTuple):
                     raise LnurlValidationError("Maximum number of uses already reached")
             tag = self.tag
             if tag == "withdrawRequest":
-                payment_hash = await pay_invoice(
-                    wallet_id=self.wallet,
-                    payment_request=query["pr"],
-                )
+                try:
+                    payment_hash = await pay_invoice(
+                        wallet_id=self.wallet,
+                        payment_request=query["pr"],
+                    )
+                except Exception as exc:
+                    raise LnurlValidationError(f"Failed to pay invoice: {exc.message}")
                 if not payment_hash:
                     raise LnurlValidationError("Failed to pay invoice")
 

lnbits/extensions/lnticket/views_api.py

@@ -116,12 +116,16 @@ async def api_ticket_make_ticket(form_id):
 
     nwords = len(re.split(r"\s+", g.data["ltext"]))
     sats = g.data["sats"]
-    payment_hash, payment_request = await create_invoice(
-        wallet_id=form.wallet,
-        amount=sats,
-        memo=f"ticket with {nwords} words on {form_id}",
-        extra={"tag": "lnticket"},
-    )
+
+    try:
+        payment_hash, payment_request = await create_invoice(
+            wallet_id=form.wallet,
+            amount=sats,
+            memo=f"ticket with {nwords} words on {form_id}",
+            extra={"tag": "lnticket"},
+        )
+    except Exception as e:
+        return jsonify({"message": str(e)}), HTTPStatus.INTERNAL_SERVER_ERROR
 
     ticket = await create_ticket(
         payment_hash=payment_hash, wallet=form.wallet, **g.data

lnbits/extensions/offlineshop/lnurl.py

@@ -64,15 +64,19 @@ async def lnurl_callback(item_id):
         )
 
     shop = await get_shop(item.shop)
-    payment_hash, payment_request = await create_invoice(
-        wallet_id=shop.wallet,
-        amount=int(amount_received / 1000),
-        memo=item.name,
-        description_hash=hashlib.sha256(
-            (await item.lnurlpay_metadata()).encode("utf-8")
-        ).digest(),
-        extra={"tag": "offlineshop", "item": item.id},
-    )
+
+    try:
+        payment_hash, payment_request = await create_invoice(
+            wallet_id=shop.wallet,
+            amount=int(amount_received / 1000),
+            memo=item.name,
+            description_hash=hashlib.sha256(
+                (await item.lnurlpay_metadata()).encode("utf-8")
+            ).digest(),
+            extra={"tag": "offlineshop", "item": item.id},
+        )
+    except Exception as exc:
+        return jsonify(LnurlErrorResponse(reason=exc.message).dict())
 
     resp = LnurlPayActionResponse(
         pr=payment_request,

lnbits/extensions/subdomains/views_api.py

@@ -1,15 +1,10 @@
-import re
 from quart import g, jsonify, request
 from http import HTTPStatus
-from lnbits.core import crud
-import json
 
-import httpx
-from lnbits.core.crud import get_user, get_wallet
+from lnbits.core.crud import get_user
 from lnbits.core.services import create_invoice, check_invoice_status
 from lnbits.decorators import api_check_wallet_key, api_validate_post_request
 
-from .util import isValidDomain, isvalidIPAddress
 from . import subdomains_ext
 from .crud import (
     create_subdomain,
@@ -169,12 +164,16 @@ async def api_subdomain_make_subdomain(domain_id):
 
     ## ALL OK - create an invoice and return it to the user
     sats = g.data["sats"]
-    payment_hash, payment_request = await create_invoice(
-        wallet_id=domain.wallet,
-        amount=sats,
-        memo=f"subdomain {g.data['subdomain']}.{domain.domain} for {sats} sats for {g.data['duration']} days",
-        extra={"tag": "lnsubdomain"},
-    )
+
+    try:
+        payment_hash, payment_request = await create_invoice(
+            wallet_id=domain.wallet,
+            amount=sats,
+            memo=f"subdomain {g.data['subdomain']}.{domain.domain} for {sats} sats for {g.data['duration']} days",
+            extra={"tag": "lnsubdomain"},
+        )
+    except Exception as e:
+        return jsonify({"message": str(e)}), HTTPStatus.INTERNAL_SERVER_ERROR
 
     subdomain = await create_subdomain(
         payment_hash=payment_hash, wallet=domain.wallet, **g.data

lnbits/extensions/withdraw/lnurl.py

@@ -119,11 +119,10 @@ async def api_lnurl_callback(unique_hash):
 
         await update_withdraw_link(link.id, **changes)
     except ValueError as e:
-        return jsonify({"status": "ERROR", "reason": str(e)}), HTTPStatus.OK
+        return jsonify({"status": "ERROR", "reason": str(e)})
     except PermissionError:
-        return (
-            jsonify({"status": "ERROR", "reason": "Withdraw link is empty."}),
-            HTTPStatus.OK,
-        )
+        return jsonify({"status": "ERROR", "reason": "Withdraw link is empty."})
+    except Exception as e:
+        return jsonify({"status": "ERROR", "reason": str(e)})
 
     return jsonify({"status": "OK"}), HTTPStatus.OK