Michilis/lnbits
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix login logout on safari (#2309)

Browse Source 
* fix: relax security level for public cookies

* fix: corner case for logout
This commit is contained in:
Vlad Stan
2024-03-07 09:22:42 +00:00
committed by GitHub
parent 884a1b9d6f
commit cb5c9b03bf
3 changed files with 6 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lnbits/core/views/auth_api.py
+4 -6
View File
@@ -142,6 +142,8 @@ async def logout() -> JSONResponse:
response.delete_cookie("cookie_access_token")
response.delete_cookie("is_lnbits_user_authorized")
response.delete_cookie("is_access_token_expired")
response.delete_cookie("lnbits_last_active_wallet")
return response
@@ -286,9 +288,7 @@ def _auth_success_response(
)
response = JSONResponse({"access_token": access_token, "token_type": "bearer"})
response.set_cookie("cookie_access_token", access_token, httponly=True)
response.set_cookie(
"is_lnbits_user_authorized", "true", samesite="none", secure=True
)
response.set_cookie("is_lnbits_user_authorized", "true")
response.delete_cookie("is_access_token_expired")
return response
@@ -298,9 +298,7 @@ def _auth_redirect_response(path: str, email: str) -> RedirectResponse:
access_token = create_access_token(data={"sub": "" or "", "email": email})
response = RedirectResponse(path)
response.set_cookie("cookie_access_token", access_token, httponly=True)
response.set_cookie(
"is_lnbits_user_authorized", "true", samesite="none", secure=True
)
response.set_cookie("is_lnbits_user_authorized", "true")
response.delete_cookie("is_access_token_expired")
return response