refactor: extract models (#2759)

tests/unit/test_services_fees.py

@@ -1,7 +1,6 @@
 import pytest
 
 from lnbits.core.services import (
-    fee_reserve,
     fee_reserve_total,
     service_fee,
 )
@@ -9,8 +8,8 @@ from lnbits.settings import Settings
 
 
 @pytest.mark.asyncio
-async def test_fee_reserve_internal():
-    fee = fee_reserve(10_000, internal=True)
+async def test_fee_reserve_internal(settings: Settings):
+    fee = settings.fee_reserve(10_000, internal=True)
     assert fee == 0
 
 
@@ -18,7 +17,7 @@ async def test_fee_reserve_internal():
 async def test_fee_reserve_min(settings: Settings):
     settings.lnbits_reserve_fee_percent = 2
     settings.lnbits_reserve_fee_min = 500
-    fee = fee_reserve(10000)
+    fee = settings.fee_reserve(10000)
     assert fee == 500
 
 
@@ -26,7 +25,7 @@ async def test_fee_reserve_min(settings: Settings):
 async def test_fee_reserve_percent(settings: Settings):
     settings.lnbits_reserve_fee_percent = 1
     settings.lnbits_reserve_fee_min = 100
-    fee = fee_reserve(100000)
+    fee = settings.fee_reserve(100000)
     assert fee == 1000
 
 
@@ -70,6 +69,6 @@ async def test_fee_reserve_total(settings: Settings):
     settings.lnbits_service_fee_wallet = "wallet_id"
     amount = 100_000
     fee = service_fee(amount)
-    reserve = fee_reserve(amount)
+    reserve = settings.fee_reserve(amount)
     total = fee_reserve_total(amount)
     assert fee + reserve == total