fix: time margin for deleting failed payments (#2147)

this pr adds a 15 minutes margin before deleting failed outgoing payments.

lnbits/core/models.py

@@ -221,7 +221,8 @@ class Payment(FromRowModel):
                 f"expired {expiration_date}"
             )
             await self.delete(conn)
-        elif self.is_out and status.failed:
+        # wait at least 15 minutes before deleting failed outgoing payments
+        elif self.is_out and status.failed and self.time + 900 < int(time.time()):
             logger.warning(
                 f"Deleting outgoing failed payment {self.checking_id}: {status}"
             )

tests/core/views/test_api.py

@@ -766,10 +766,10 @@ async def test_pay_hold_invoice_check_pending_and_fail_cancel_payment_task_in_me
     assert status.paid is False
 
     # now the payment should be gone after the status check
-    payment_db_after_status_check = await get_standalone_payment(
+    # payment_db_after_status_check = await get_standalone_payment(
-        invoice_obj.payment_hash
+    #     invoice_obj.payment_hash
-    )
+    # )
-    assert payment_db_after_status_check is None
+    # assert payment_db_after_status_check is None
 
 
 @pytest.mark.asyncio