Michilis/lnbits
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: fail closed on PayPal webhook verification errors (#3769)

Browse Source
This commit is contained in:
Arc
2026-02-10 08:50:50 +01:00
committed by GitHub
parent efd36d0221
commit 768d2cbe2a
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lnbits/core/services/fiat_providers.py
+4 -4
View File
@@ -118,8 +118,8 @@ async def verify_paypal_webhook(headers, payload: bytes):
""" """
webhook_id = settings.paypal_webhook_id webhook_id = settings.paypal_webhook_id
if not webhook_id: if not webhook_id:
logger.warning("PayPal webhook ID not set; skipping verification.") logger.warning("PayPal webhook ID not set.")
return raise ValueError("PayPal webhook cannot be verified. Missing webhook ID.")
required_headers = { required_headers = {
"PAYPAL-TRANSMISSION-ID": headers.get("PAYPAL-TRANSMISSION-ID"), "PAYPAL-TRANSMISSION-ID": headers.get("PAYPAL-TRANSMISSION-ID"),
@@ -129,8 +129,8 @@ async def verify_paypal_webhook(headers, payload: bytes):
"PAYPAL-AUTH-ALGO": headers.get("PAYPAL-AUTH-ALGO"), "PAYPAL-AUTH-ALGO": headers.get("PAYPAL-AUTH-ALGO"),
} }
if not all(required_headers.values()): if not all(required_headers.values()):
logger.warning("Missing PayPal webhook headers; skipping verification.") logger.warning("Missing PayPal webhook headers.")
return raise ValueError("PayPal webhook cannot be verified. Missing headers.")
try: try:
async with httpx.AsyncClient(base_url=settings.paypal_api_endpoint) as client: async with httpx.AsyncClient(base_url=settings.paypal_api_endpoint) as client: