refactor: better ID check

This commit is contained in:
Vlad Stan
2026-05-21 14:12:43 +03:00
parent 03161f8e9b
commit 3723b6510d
+5 -10
View File
@@ -380,12 +380,10 @@ async def handle_revolut_event(event: dict):
logger.warning(f"Unhandled Revolut event type: '{event_type}'.") logger.warning(f"Unhandled Revolut event type: '{event_type}'.")
async def _handle_revolut_subscription_initiated( async def _handle_revolut_subscription_initiated(event: dict):
event: dict, subscription: dict | None = None
):
subscription_id = event.get("subscription_id") subscription_id = event.get("subscription_id")
if not subscription_id and subscription: if not subscription_id:
subscription_id = subscription.get("id") subscription_id = event.get("id")
if not subscription_id: if not subscription_id:
logger.warning("Revolut subscription event missing subscription_id.") logger.warning("Revolut subscription event missing subscription_id.")
@@ -395,8 +393,7 @@ async def _handle_revolut_subscription_initiated(
if not fiat_provider: if not fiat_provider:
return return
if subscription is None: subscription = await fiat_provider.get_subscription(subscription_id)
subscription = await fiat_provider.get_subscription(subscription_id)
await _handle_revolut_subscription(subscription, fiat_provider) await _handle_revolut_subscription(subscription, fiat_provider)
@@ -493,9 +490,7 @@ async def _handle_revolut_subscription_order_paid(order_id: str):
logger.warning(f"Revolut subscription is not active: '{subscription_id}'.") logger.warning(f"Revolut subscription is not active: '{subscription_id}'.")
return return
await _handle_revolut_subscription_initiated( await _handle_revolut_subscription_initiated(subscription)
{"subscription_id": subscription_id}, subscription
)
async def _create_revolut_subscription_payment( async def _create_revolut_subscription_payment(