Backend: Unstuck outgoing payments (#857)

* first attempts

* lndrest works

* fix details

* optional fee update

* use base64.urlsafe_b64encode

* return paymentstatus

* CLN: return pending for pending invoices

* grpc wip

* lndgrpc works

* cln: return pending for pending invoices really this time

* retry wallet out of exception

* wip eclair

* take all routines into try except

* cliche: return error

* rename payment.check_pending() to payment.check_status()

* rename payment.check_pending() to payment.check_status()

* eclair: works

* eclair: better error check

* opennode: works

* check payment.checking_id istead of payment.ok

* payment.ok check as well

* cln: works?

* cln: works

* lntxbot: works

* lnbits/wallets/lnpay.py

* cln: error handling

* make format

* lndhub full detail update

* spark: wip

* error to False

* wallets: return clean PaymentResponse

* opennode: strict error

* cliche: works

* lnbits: works

* cln: dont throw error

* preimage not error

* fix cln

* do not add duplicate payments

* revert cln

* extra safety for cln

* undo crud changes until tests work

* tasks: better logging and 0.5s sleep for regular status check

* 0.1 s

* check if wallet exists

* lnbits unhashed description

* remove sleep

* revert app.py

* cleanup

* add check

* clean error

* readd app.py

* fix eclaid

lnbits/wallets/opennode.py

@@ -47,7 +47,7 @@ class OpenNodeWallet(Wallet):
         if r.is_error:
             return StatusResponse(data["message"], 0)
 
-        return StatusResponse(None, data["balance"]["BTC"] / 100_000_000_000)
+        return StatusResponse(None, data["balance"]["BTC"] * 1000)
 
     async def create_invoice(
         self,
@@ -92,11 +92,15 @@ class OpenNodeWallet(Wallet):
 
         if r.is_error:
             error_message = r.json()["message"]
-            return PaymentResponse(False, None, 0, None, error_message)
+            return PaymentResponse(False, None, None, None, error_message)
 
         data = r.json()["data"]
         checking_id = data["id"]
-        fee_msat = data["fee"] * 1000
+        fee_msat = -data["fee"] * 1000
+
+        if data["status"] != "paid":
+            return PaymentResponse(None, checking_id, fee_msat, None, "payment failed")
+
         return PaymentResponse(True, checking_id, fee_msat, None, None)
 
     async def get_invoice_status(self, checking_id: str) -> PaymentStatus:
@@ -106,9 +110,9 @@ class OpenNodeWallet(Wallet):
             )
         if r.is_error:
             return PaymentStatus(None)
-
-        statuses = {"processing": None, "paid": True, "unpaid": False}
-        return PaymentStatus(statuses[r.json()["data"]["status"]])
+        data = r.json()["data"]
+        statuses = {"processing": None, "paid": True, "unpaid": None}
+        return PaymentStatus(statuses[data.get("status")])
 
     async def get_payment_status(self, checking_id: str) -> PaymentStatus:
         async with httpx.AsyncClient() as client:
@@ -119,14 +123,16 @@ class OpenNodeWallet(Wallet):
         if r.is_error:
             return PaymentStatus(None)
 
+        data = r.json()["data"]
         statuses = {
             "initial": None,
             "pending": None,
             "confirmed": True,
-            "error": False,
+            "error": None,
             "failed": False,
         }
-        return PaymentStatus(statuses[r.json()["data"]["status"]])
+        fee_msat = -data.get("fee") * 1000
+        return PaymentStatus(statuses[data.get("status")], fee_msat)
 
     async def paid_invoices_stream(self) -> AsyncGenerator[str, None]:
         self.queue: asyncio.Queue = asyncio.Queue(0)