refactor: extract helpers, move private functions to the bottom

tests/unit/test_services_assets.py

@@ -2,45 +2,26 @@ from io import BytesIO
 from uuid import uuid4
 
 import pytest
-from fastapi import UploadFile
 from PIL import Image
 from pytest_mock.plugin import MockerFixture
-from starlette.datastructures import Headers
 
 from lnbits.core.crud import create_account
 from lnbits.core.crud.assets import get_user_asset, get_user_assets_count
 from lnbits.core.models import Account
 from lnbits.core.services.assets import create_user_asset, thumbnail_from_bytes
 from lnbits.settings import Settings
-
-
-async def _create_user() -> str:
-    user_id = uuid4().hex
-    await create_account(Account(id=user_id, username=f"user_{user_id[:8]}"))
-    return user_id
-
-
-def _make_upload_file(
-    contents: bytes,
-    *,
-    filename: str,
-    content_type: str | None,
-) -> UploadFile:
-    headers = (
-        Headers({"content-type": content_type}) if content_type is not None else None
-    )
-    return UploadFile(BytesIO(contents), filename=filename, headers=headers)
+from tests.helpers import make_upload_file
 
 
 @pytest.mark.anyio
 async def test_create_user_asset_validates_upload_constraints(
     settings: Settings, mocker: MockerFixture
 ):
-    file_without_type = _make_upload_file(b"hello", filename="a.txt", content_type=None)
+    file_without_type = make_upload_file(b"hello", filename="a.txt", content_type=None)
     with pytest.raises(ValueError, match="File must have a content type."):
         await create_user_asset("user-1", file_without_type, is_public=False)
 
-    bad_type = _make_upload_file(
+    bad_type = make_upload_file(
         b"hello",
         filename="bad.bin",
         content_type="application/x-msdownload",
@@ -58,12 +39,12 @@ async def test_create_user_asset_validates_upload_constraints(
         settings.lnbits_max_asset_size_mb = 1
         settings.lnbits_assets_no_limit_users = []
         limited_user = await _create_user()
-        allowed_type = _make_upload_file(
+        allowed_type = make_upload_file(
             b"hello", filename="ok.txt", content_type="text/plain"
         )
         await create_user_asset(limited_user, allowed_type, is_public=False)
 
-        blocked_by_count = _make_upload_file(
+        blocked_by_count = make_upload_file(
             b"again",
             filename="again.txt",
             content_type="text/plain",
@@ -73,7 +54,7 @@ async def test_create_user_asset_validates_upload_constraints(
 
         settings.lnbits_max_asset_size_mb = 0.000001
         oversized_user = await _create_user()
-        large_file = _make_upload_file(
+        large_file = make_upload_file(
             b"0123456789",
             filename="ok.txt",
             content_type="text/plain",
@@ -93,7 +74,7 @@ async def test_create_user_asset_success(mocker: MockerFixture):
         "lnbits.core.services.assets.thumbnail_from_bytes",
         return_value=None,
     )
-    file = _make_upload_file(b"hello", filename="hello.txt", content_type="text/plain")
+    file = make_upload_file(b"hello", filename="hello.txt", content_type="text/plain")
 
     asset = await create_user_asset(user_id, file, is_public=True)
     stored = await get_user_asset(user_id, asset.id)
@@ -120,3 +101,9 @@ def test_thumbnail_from_bytes_success_and_failure():
     assert thumbnail is not None
     assert isinstance(thumbnail.getvalue(), bytes)
     assert thumbnail_from_bytes(b"not-an-image") is None
+
+
+async def _create_user() -> str:
+    user_id = uuid4().hex
+    await create_account(Account(id=user_id, username=f"user_{user_id[:8]}"))
+    return user_id