refactor: code review

lnbits/wallets/lntxbot.py

@@ -1,7 +1,6 @@
-from requests import Response, get, post
-from flask import jsonify
-from .base import InvoiceResponse, TxStatus, Wallet, PaymentResponse
-import json
+from requests import post
+
+from .base import InvoiceResponse, PaymentResponse, TxStatus, Wallet
 
 
 class LntxbotWallet(Wallet):
@@ -23,11 +22,17 @@ class LntxbotWallet(Wallet):
         return InvoiceResponse(r, payment_hash, payment_request)
 
     def pay_invoice(self, bolt11: str) -> PaymentResponse:
-        fee_msat = None
         r = post(url=f"{self.endpoint}/payinvoice", headers=self.auth_admin, json={"invoice": bolt11})
-        return PaymentResponse(r)
+        failed, fee_msat = not r.ok, 0
 
+        if r.ok:
+            data = r.json()
+            if "error" in data and data["error"]:
+                failed = True
+            elif "fee_msat" in data:
+                fee_msat = data["fee_msat"]
 
+        return PaymentResponse(r, failed, fee_msat)
 
     def get_invoice_status(self, payment_hash: str, wait: bool = True) -> TxStatus:
         wait = "true" if wait else "false"
@@ -42,7 +47,6 @@ class LntxbotWallet(Wallet):
 
         return TxStatus(r, True)
 
-
     def get_payment_status(self, payment_hash: str) -> TxStatus:
         r = post(url=f"{self.endpoint}/paymentstatus/{payment_hash}", headers=self.auth_invoice)
         data = r.json()
@@ -51,5 +55,3 @@ class LntxbotWallet(Wallet):
             return TxStatus(r, None)
 
         return TxStatus(r, {"complete": True, "failed": False, "unknown": None}[data.get("status", "unknown")])
-
-