phase-4: the live tax position, deadlines and the notifications behind them

The dashboard, the deadline engine, the three sweeps and the notification
channels. Confirm a comprobante and the IVA and IRP figures move; every
headline number opens the documents behind it.

The dashboard does no arithmetic of its own: it picks inputs and calls
packages/rules. The acceptance test asserts the API's numbers equal what
computeF120 and computeF515 produce over the same rows, before and after the
bandeja is confirmed, so a drift in either direction fails.

Deadlines come from the calendario perpetuo, skipping any period earlier than
the date the taxpayer took the obligation on. Without that guard a brand new
account opens on a red overdue card for a period that predates it.

Sweeps are idempotent by dedupe key rather than bookkeeping: a restarted
poller, a second replica and a crash mid-sweep all converge on one run, and one
reminder per user per period per milestone. They queue notifications rather
than sending them, so a channel being down retries on the job schedule. The
T-10 test derives the date from dueDateFor rather than restating the calendar.

Auto-confirm only touches what the rules were confident about and never a
decision the user already made. An unconfigured channel is absent rather than
broken: the fan-out skips it, the UI hides it, and a frozen account receives
nothing.

Web: the dashboard's three zones with swipeable position cards and traceable
numbers, the deadlines timeline, and the app shell with the tab bar and the
persistent scan button FLOWS.md asks for.

Two additions to the specs, both marked: hasDocuments on DashboardDto, without
which a position of all zeros is indistinguishable from a real one and the
first-run state never shows; and an insight_dismissals table, which FLOWS.md
requires and SPEC.md has nowhere to put.

Also: pnpm db:reset, because the e2e suite changes the seed it runs against and
a suite that is not repeatable is not a suite.

280 vitest tests, 51 Playwright tests, rules coverage still 100%, typecheck and
lint clean.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
Michilis
2026-09-04 04:42:32 +00:00
co-authored by Claude Opus 5
parent b074456b70
commit 5dc284c5f2
42 changed files with 2915 additions and 66 deletions
+118
View File
@@ -0,0 +1,118 @@
import { es } from '@impuestos/i18n';
import { expect, test, type Page } from '@playwright/test';
async function signIn(page: Page): Promise<void> {
await page.goto('/es/login');
await page.getByLabel(es['auth.register.email']).fill('maria@demo.local');
await page.getByLabel(es['auth.login.password']).fill('demo-maria-1');
await page.getByRole('button', { name: es['auth.login.submit'] }).click();
await expect(page).toHaveURL(/\/es\/inicio$/);
}
/** Flow C, read only: the position, the single next action and the insight feed. */
test.describe('dashboard', () => {
test.beforeEach(async ({ page }) => {
await signIn(page);
});
test('shows the IVA and IRP position with real figures', async ({ page }) => {
await expect(page.getByRole('heading', { name: es['home.title'] })).toBeVisible();
// Both obligations are active for the showcase account.
await expect(page.getByText(es['home.iva.title'].split('{')[0] as string)).toBeVisible();
await expect(page.getByText(es['home.irp.title'].split('{')[0] as string)).toBeVisible();
// Money is always Gs. and never localized.
await expect(page.getByText(/Gs\. [\d.]+/).first()).toBeVisible();
});
test('opens the documents behind a headline number', async ({ page }) => {
await expect(page.getByText(es['home.iva.title'].split('{')[0] as string)).toBeVisible();
await page.getByRole('button', { name: /^Gs\./ }).first().click();
const dialog = page.getByRole('dialog');
await expect(dialog).toBeVisible();
await expect(dialog.getByRole('heading', { name: es['home.trace.title'] })).toBeVisible();
await dialog.getByRole('button', { name: es['common.close'] }).click();
await expect(dialog).toBeHidden();
});
test('offers exactly one next action', async ({ page }) => {
// Wait for the position, or the action strip has not rendered yet.
await expect(page.getByText(es['home.iva.title'].split('{')[0] as string)).toBeVisible();
// Whichever card wins, there is one of them and it has one button.
const shell = page.locator('main');
const actions = shell.getByRole('link', {
name: new RegExp(
[
es['home.next.overdueCta'],
es['home.next.reviewCta'],
es['home.next.deadlineCta'],
es['home.next.bandejaCta'],
].join('|'),
),
});
// all_clear is the one kind with nothing to click, which is still one card.
const allClear = page.getByText(es['home.next.allClear']);
expect((await actions.count()) + (await allClear.count())).toBe(1);
});
test('dismisses an insight and does not offer it again', async ({ page }) => {
// Wait for the position to land, or the feed has not rendered yet.
await expect(page.getByText(es['home.iva.title'].split('{')[0] as string)).toBeVisible();
const dismiss = page.getByRole('button', { name: es['home.insight.dismiss'] });
const before = await dismiss.count();
// Dismissals persist by design, so a stack that has already been cleared by an earlier
// run has nothing to offer. The persistence guarantee itself is covered against the
// API in dashboard.test.ts, which starts from a fresh database every time.
test.skip(before === 0, 'every insight for this account has already been dismissed');
await dismiss.first().click();
await expect(async () => {
expect(await page.getByRole('button', { name: es['home.insight.dismiss'] }).count()).toBeLessThan(before);
}).toPass({ timeout: 10_000 });
await page.reload();
expect(await page.getByRole('button', { name: es['home.insight.dismiss'] }).count()).toBeLessThan(before);
});
});
test.describe('the app shell', () => {
test.beforeEach(async ({ page }) => {
await signIn(page);
});
test('carries the scan button and the four tabs on every screen', async ({ page }) => {
for (const path of ['/es/inicio', '/es/bandeja', '/es/comprobantes', '/es/vencimientos']) {
await page.goto(path);
await expect(page.getByRole('link', { name: es['scan.fab'] })).toBeVisible();
for (const key of ['nav.inicio', 'nav.bandeja', 'nav.comprobantes', 'nav.vencimientos'] as const) {
await expect(page.getByRole('link', { name: es[key], exact: true })).toBeVisible();
}
}
});
test('the scan button reaches the scanner', async ({ page }) => {
await page.getByRole('link', { name: es['scan.fab'] }).click();
await expect(page).toHaveURL(/\/es\/escanear$/);
});
});
test.describe('vencimientos', () => {
test('explains the filing day and lists what is coming', async ({ page }) => {
await signIn(page);
await page.goto('/es/vencimientos');
await expect(page.getByRole('heading', { name: es['vto.title'] })).toBeVisible();
// Her RUC base ends in 6, which RULES.md puts on the 19th.
await expect(
page.getByText(es['vto.explainer'].replace('{digit}', '6').replace('{day}', '19')),
).toBeVisible();
await expect(page.getByRole('listitem').first()).toBeVisible();
await expect(page.getByText(es['obligation.iva_120']).first()).toBeVisible();
});
});