phase-2: identity, from the landing hook to the profile screen

Flows A1 to A6 and E3 end to end. A visitor types a RUC on the landing page,
sees their real filing dates, registers, verifies a six digit code, grants
consent, completes a three step setup and lands on the first run screen, with
the profile, consent and audit rows to show for it.

API: public RUC lookup behind a token bucket (10/min/IP), the full /me surface
(profile, dependents, consents, notification prefs, data export, account
deletion), an append-only audit module that exports an insert and nothing else,
and a PII module that is the only thing allowed near those tables.

Deletion and consent revocation both freeze the account and drop every session,
reusing better-auth's ban flag rather than adding a second notion of disabled.
Nothing is destroyed yet: the purge is a job for phase 4. deadlineDigit is
always derived server side, never accepted from the client.

Web: landing with the RUC hook, registration, OTP verification, consent, the
setup wizard, the profile screen with "Tus datos", and legal pages that ship as
marked placeholders per COPY.md section 13. Money, Skeleton, Switch and
EmptyState components added.

The seed is now complete for identity: Maria at 4123456-1, filing digit 6 and
day 19, with a dependant, consents and prefs; Carlos as an IVA-only company.

Two real defects found by building the screens and fixed with tests:
the OTP boxes dropped a digit because the handler fired effects inside a
setState updater that React 19 invokes twice, and the switch knob rendered
outside its track because translate-x-5.5 does not resolve.

232 vitest tests, 26 Playwright tests across mobile and desktop, coverage still
100% on the rules, typecheck and lint clean.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
Michilis
2026-09-03 23:33:10 +00:00
co-authored by Claude Opus 5
parent 80b10c958e
commit 0d7651b17c
61 changed files with 3776 additions and 82 deletions
+111
View File
@@ -0,0 +1,111 @@
import { es } from '@impuestos/i18n';
import { expect, test } from '@playwright/test';
import { readAuditActions } from './db';
/** Flow E3. The trust screen: what we hold, and the two ways to take it back. */
test.describe('profile', () => {
test.beforeEach(async ({ page }) => {
await page.goto('/es/login');
await page.getByLabel(es['auth.register.email']).fill('maria@demo.local');
await page.getByLabel(es['auth.login.password']).fill('demo-maria-1');
await page.getByRole('button', { name: es['auth.login.submit'] }).click();
await expect(page).toHaveURL(/\/es\/inicio$/);
});
test('shows the seeded identity, dependants and the data section', async ({ page }) => {
await page.goto('/es/perfil');
await expect(page.getByLabel(es['setup.fullName'])).toHaveValue('Maria Gonzalez');
await expect(page.getByLabel(es['setup.docLabel'])).toHaveValue('4123456-1');
// Base ends in 6, so RULES.md puts her deadline on the 19th.
await expect(page.getByText(es['vto.explainer'].replace('{digit}', '6').replace('{day}', '19'))).toBeVisible();
await expect(page.getByText('Lucas Gonzalez')).toBeVisible();
await expect(
page.getByRole('heading', { name: es['profile.myData.title'], exact: true }),
).toBeVisible();
await expect(page.getByRole('link', { name: es['profile.myData.export'] })).toBeVisible();
});
test('adds and removes a dependant', async ({ page }) => {
await page.goto('/es/perfil');
const name = `Prueba ${Date.now()}`;
await page.getByLabel(es['setup.dependents.name'], { exact: true }).fill(name);
await page.getByRole('button', { name: es['setup.dependents.add'] }).click();
await expect(page.getByText(name)).toBeVisible();
await page
.getByRole('listitem')
.filter({ hasText: name })
.getByRole('button', { name: es['common.remove'] })
.click();
await expect(page.getByText(name)).toBeHidden();
expect(readAuditActions('maria@demo.local')).toContain('dependent.create');
expect(readAuditActions('maria@demo.local')).toContain('dependent.delete');
});
test('the export downloads a file holding the profile', async ({ page }) => {
await page.goto('/es/perfil');
const download = page.waitForEvent('download');
await page.getByRole('link', { name: es['profile.myData.export'] }).click();
const file = await download;
expect(file.suggestedFilename()).toMatch(/^impuestos-datos-\d{4}-\d{2}-\d{2}\.json$/);
const stream = await file.createReadStream();
const chunks: Buffer[] = [];
for await (const chunk of stream) chunks.push(chunk as Buffer);
const data = JSON.parse(Buffer.concat(chunks).toString('utf8')) as {
profile: { fullName: string } | null;
account: { email: string };
};
expect(data.account.email).toBe('maria@demo.local');
expect(data.profile?.fullName).toBe('Maria Gonzalez');
expect(readAuditActions('maria@demo.local')).toContain('data.export');
});
test('deleting the account asks for the email before it will proceed', async ({ page }) => {
await page.goto('/es/perfil');
await page.getByRole('button', { name: es['profile.myData.delete'] }).click();
const confirm = page.getByRole('button', { name: es['profile.myData.deleteCta'] });
await expect(confirm).toBeDisabled();
await page.getByLabel(es['profile.myData.deletePrompt'].replace('{email}', 'maria@demo.local')).fill('nope@demo.local');
await expect(confirm).toBeDisabled();
// Stops short of confirming: this account is the showcase data for every other test.
await page.getByRole('button', { name: es['common.cancel'] }).click();
});
});
/** The toggle knob used to render outside its track, which read as a broken control. */
test.describe('switch', () => {
test('keeps its knob inside the track in both states', async ({ page }) => {
await page.goto('/es/login');
await page.getByLabel(es['auth.register.email']).fill('maria@demo.local');
await page.getByLabel(es['auth.login.password']).fill('demo-maria-1');
await page.getByRole('button', { name: es['auth.login.submit'] }).click();
await expect(page).toHaveURL(/\/es\/inicio$/);
await page.goto('/es/perfil');
const toggle = page.getByRole('switch', { name: es['setup.oblig.iva.title'] });
await expect(toggle).toBeVisible();
for (const _ of [0, 1]) {
const track = await toggle.boundingBox();
const knob = await toggle.locator('span').boundingBox();
expect(track).not.toBeNull();
expect(knob).not.toBeNull();
expect(knob?.x ?? 0).toBeGreaterThanOrEqual(track?.x ?? 0);
expect((knob?.x ?? 0) + (knob?.width ?? 0)).toBeLessThanOrEqual(
(track?.x ?? 0) + (track?.width ?? 0),
);
await toggle.click();
await page.waitForTimeout(250);
}
});
});